Allow the homeserver to perform introspection using a shared secret #4808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandhose
added
A-Homeserver-Integration
Deploying matrix-authentication-service-docs with
|
| Latest commit: |
85be5e1
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://1a1e2c61.matrix-authentication-service-docs.pages.dev |
| Branch Preview URL: | https://quenting-introspection-with.matrix-authentication-service-docs.pages.dev |
sandhose
force-pushed
the
quenting/introspection-with-shared-token
branch
from
e603fd7 to
74bd3fe
Compare
reivilibre
approved these changes
Jul 22, 2025
| // Basic and Bearer at the same time, so we need to parse them manually | ||
| let authorization = if let Some(header) = req.headers().get(http::header::AUTHORIZATION) { | ||
| let bytes = header.as_bytes(); | ||
| if bytes.len() >= 6 && bytes[..6].eq_ignore_ascii_case(b"Basic ") { |
There was a problem hiding this comment.
Suggested change
| if bytes.len() >= 6 && bytes[..6].eq_ignore_ascii_case(b"Basic ") { | |
| if bytes.starts_with(b"Basic ") { |
There was a problem hiding this comment.
We want to make a case-insensitive comparison, hence the eq_ignore_ascii_case
| decoded.username().to_owned(), | ||
| decoded.password().to_owned(), | ||
| )) | ||
| } else if bytes.len() >= 7 && bytes[..7].eq_ignore_ascii_case(b"Bearer ") { |
There was a problem hiding this comment.
Suggested change
| } else if bytes.len() >= 7 && bytes[..7].eq_ignore_ascii_case(b"Bearer ") { | |
| } else if bytes.starts_with(b"Bearer ") { |
Co-authored-by: reivilibre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intent is to simplify the setup process by only requiring a shared secret between the HS and MAS, instead of having to provision a static client for the HS.